-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Table): Change column width to match style guidelines #850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spartDev
force-pushed
the
fix/table_max-width
branch
from
November 5, 2019 17:17
2bea065
to
544af96
Compare
anglol
force-pushed
the
fix/table_max-width
branch
from
November 6, 2019 13:38
544af96
to
867a1dd
Compare
I just added the shadows on scroll. |
anglol
force-pushed
the
fix/table_max-width
branch
2 times, most recently
from
November 6, 2019 14:08
00a3ed5
to
d7256ce
Compare
sun-tea
suggested changes
Nov 6, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
anglol
force-pushed
the
fix/table_max-width
branch
2 times, most recently
from
November 6, 2019 16:54
94ece48
to
af3e39f
Compare
anglol
force-pushed
the
fix/table_max-width
branch
from
November 6, 2019 17:08
af3e39f
to
ea67da7
Compare
ArTiSTiX
approved these changes
Nov 6, 2019
sun-tea
approved these changes
Nov 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is already done in that PR :
How that works :
100% / column's number + 1
display: flex
attribut which lead to an issue on safari :icon is not aligned anymore
What is need to be done :
I already started that point. The way I think the solution :
Related / Associated Jira Cards :
Todo - Checklist: